Chromium Code Reviews Chromium Code Reviews
Issue 1984473002:
[Telemetry] Add BattOr benchmark. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # Copyright 2012 The Chromium Authors. All rights reserved. | 1 # Copyright 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Presubmit script for changes affecting tools/perf/. | 5 """Presubmit script for changes affecting tools/perf/. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 25 return results | 25 return results |
| 26 | 26 |
| 27 | 27 |
| 28 def _GetPathsToPrepend(input_api): | 28 def _GetPathsToPrepend(input_api): |
| 29 perf_dir = input_api.PresubmitLocalPath() | 29 perf_dir = input_api.PresubmitLocalPath() |
| 30 chromium_src_dir = input_api.os_path.join(perf_dir, '..', '..') | 30 chromium_src_dir = input_api.os_path.join(perf_dir, '..', '..') |
| 31 telemetry_dir = input_api.os_path.join( | 31 telemetry_dir = input_api.os_path.join( |
| 32 chromium_src_dir, 'third_party', 'catapult', 'telemetry') | 32 chromium_src_dir, 'third_party', 'catapult', 'telemetry') |
| 33 experimental_dir = input_api.os_path.join( | 33 experimental_dir = input_api.os_path.join( |
| 34 chromium_src_dir, 'third_party', 'catapult', 'experimental') | 34 chromium_src_dir, 'third_party', 'catapult', 'experimental') |
| 35 battor_dir = input_api.os_path.join( | |
|
nednguyen
2016/05/25 19:50:11
We no longer need this change
rnephew (Reviews Here)
2016/05/25 20:41:31
Done.
| |
| 36 chromium_src_dir, 'third_party', 'catapult', 'common', 'battor', 'battor') | |
| 35 return [ | 37 return [ |
| 36 telemetry_dir, | 38 telemetry_dir, |
| 37 input_api.os_path.join(telemetry_dir, 'third_party', 'mock'), | 39 input_api.os_path.join(telemetry_dir, 'third_party', 'mock'), |
| 38 experimental_dir, | 40 experimental_dir, |
| 41 battor_dir, | |
| 39 ] | 42 ] |
| 40 | 43 |
| 41 | 44 |
| 42 def _CheckWprShaFiles(input_api, output_api): | 45 def _CheckWprShaFiles(input_api, output_api): |
| 43 """Check whether the wpr sha files have matching URLs.""" | 46 """Check whether the wpr sha files have matching URLs.""" |
| 44 old_sys_path = sys.path | 47 old_sys_path = sys.path |
| 45 try: | 48 try: |
| 46 perf_dir = input_api.PresubmitLocalPath() | 49 perf_dir = input_api.PresubmitLocalPath() |
| 47 catapult_path = os.path.abspath(os.path.join( | 50 catapult_path = os.path.abspath(os.path.join( |
| 48 perf_dir, '..', '..', 'third_party', 'catapult', 'catapult_base')) | 51 perf_dir, '..', '..', 'third_party', 'catapult', 'catapult_base')) |
| (...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 135 bots_string = ';'.join(bots) | 138 bots_string = ';'.join(bots) |
| 136 description = original_description | 139 description = original_description |
| 137 description += '\nCQ_EXTRA_TRYBOTS=%s' % bots_string | 140 description += '\nCQ_EXTRA_TRYBOTS=%s' % bots_string |
| 138 results.append(output_api.PresubmitNotifyResult( | 141 results.append(output_api.PresubmitNotifyResult( |
| 139 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.')) | 142 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.')) |
| 140 | 143 |
| 141 if description != original_description: | 144 if description != original_description: |
| 142 rietveld_obj.update_description(issue, description) | 145 rietveld_obj.update_description(issue, description) |
| 143 | 146 |
| 144 return results | 147 return results |
| OLD | NEW |
