[Telemetry] Add BattOr benchmark.

tools/perf/benchmarks/battor.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import os
+import sys
+
+from core import path_util
+from core import perf_benchmark
+from telemetry.web_perf import timeline_based_measurement
+import page_sets
+
+
+BATTOR_PATH = os.path.join(

[rnephew (Reviews Here), 2016/05/17 18:54:16]

Is there a better place to add this to the python path? I originally did it in
run_benchmark, but then that caused problems with WPR recording since it wasn't
in the path there.

[nednguyen, 2016/05/18 02:15:18]

Here is ok. Ideally, the tools/perf should follow the double-project-name
(tools/perf/perf) folder of our python projects & we add the BATTOR_PATH to
tools/perf/perf/__init__.py but it's now super annoying to do this refactoring

+    path_util.GetTelemetryDir(), '..', 'common', 'battor', 'battor')
+sys.path.insert(1, BATTOR_PATH)
+import battor_wrapper
+
+class _BattOrBenchmark(perf_benchmark.PerfBenchmark):
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    options = timeline_based_measurement.Options()
+    options.config.enable_battor_trace = True
+    # TODO(rnephew): Enable chrome trace when clock syncs work well with it.
+    options.config.enable_chrome_trace = False
+    options.SetTimelineBasedMetric('SystemHealthMetrics')
+    return options
+
+  @classmethod
+  def ShouldDisable(cls, browser):
+    # Only run if BattOr is detected.
+    test_platform = browser.platform.GetOSName()
+    # pylint: disable=protected-access
+    device = (browser.platform._platform_backend.device

[nednguyen, 2016/05/18 02:15:17]

Accessing _platform_backend here violates the private API contract. Can you make
a CL that creates a platform.IsBattorConnected() method on telemetry side?

[nednguyen, 2016/05/18 02:17:07]

err, sorry. Let's name it platform.HasBattorConnected() :-)

[rnephew (Reviews Here), 2016/05/19 16:50:03]

Done. Needs https://codereview.chromium.org/1997633003/ to land.

+              if test_platform == 'android' else None)
+    if not battor_wrapper.IsBattOrConnected(test_platform,
+                                            android_device=device):
+      return True
+
+    # Galaxy S5s have problems with running system health metrics.
+    # http://crbug.com/600463
+    galaxy_s5_type_name = 'SM-G900H'
+    return browser.platform.GetDeviceTypeName() == galaxy_s5_type_name
+
+  @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return True
+
+
+class BattOrPowerMobileSites(_BattOrBenchmark):
+  page_set = page_sets.power_cases.PowerCasesPageSet
+
+  @classmethod
+  def Name(cls):
+    return 'BattOr.BattOrCases'
+