Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1984463002: More cleanup: Get rid of ServiceConnectorRegistry. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work791_app_conn_devo_4
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

More cleanup: Get rid of ServiceConnectorRegistry. Just move its stuff (which isn't very complicated) directly into ServiceProviderImpl. Also simplify ServiceConnector a bit. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0da9363de2a371efc344d8aab7420a310572247e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -137 lines) Patch
M mojo/public/cpp/application/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/application/lib/service_connector_registry.h View 1 chunk +0 lines, -59 lines 0 comments Download
D mojo/public/cpp/application/lib/service_connector_registry.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M mojo/public/cpp/application/lib/service_provider_impl.cc View 2 chunks +18 lines, -5 lines 0 comments Download
M mojo/public/cpp/application/service_connector.h View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/service_provider_impl.h View 5 chunks +16 lines, -19 lines 0 comments Download

Depends on Patchset:

Issue 1977023003 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
Delete all the files!
4 years, 7 months ago (2016-05-13 23:34:39 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-14 01:37:27 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-14 02:18:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0da9363de2a371efc344d8aab7420a310572247e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698