Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977023003: ApplicationConnection devolution, part 4 (the end). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work790_app_conn_devo_3.1
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 4 (the end). Nuke ApplicationConnection and ServiceRegistry. Also clean up includes. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b237bca1446a4ef1006f2804ecdfeb1a0cf286ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -174 lines) Patch
M examples/apptest/example_service_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/bank_app/bank.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo/echo_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo_terminal/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/forwarding_content_handler/forwarding_content_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/hello_mojo/hello_mojo_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/indirect_service/indirect_integer_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/indirect_service/integer_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/media_test/media_test_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/native_run_app/native_run_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/spinning_cube/spinning_cube_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/trace_me/trace_me_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/trace_provider_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/public/cpp/application/application_connection.h View 1 chunk +0 lines, -27 lines 0 comments Download
M mojo/public/cpp/application/application_impl.h View 3 chunks +3 lines, -4 lines 0 comments Download
D mojo/public/cpp/application/lib/application_connection.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M mojo/public/cpp/application/lib/service_connector_registry.cc View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/cpp/application/lib/service_registry.h View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/public/cpp/application/lib/service_registry.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/ui/view_provider_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/asset_bundle/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/authentication/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/clipboard/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/device_info/device_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/files/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/compositor_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/icu_data/icu_data_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/keyboard/linux/keyboard_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/keyboard/linux/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/log/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/nonsfi/pnacl_compile.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/nonsfi/pnacl_link.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/sfi/content_handler_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/native_support/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/prediction_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/test_service/test_service_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_manager/input_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/launcher/launch_instance.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/launcher/launcher_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/view_manager/view_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/ipc_init_helper_mojo.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1983473002 Patch 1

Dependent Patchsets:

Issue 1984463002 Patch 1

Messages

Total messages: 5 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1983473002/.
4 years, 7 months ago (2016-05-13 23:04:14 UTC) #1
viettrungluu
On 2016/05/13 23:04:14, viettrungluu wrote: > Depends on https://codereview.chromium.org/1983473002/. (The only interesting changes are in ...
4 years, 7 months ago (2016-05-13 23:04:38 UTC) #2
vardhan
lgtm
4 years, 7 months ago (2016-05-13 23:32:34 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-13 23:35:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b237bca1446a4ef1006f2804ecdfeb1a0cf286ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698