Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: mojo/public/cpp/application/lib/service_connector_registry.h

Issue 1984463002: More cleanup: Get rid of ServiceConnectorRegistry. (Closed) Base URL: https://github.com/domokit/mojo.git@work791_app_conn_devo_4
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/application/BUILD.gn ('k') | mojo/public/cpp/application/lib/service_connector_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/application/lib/service_connector_registry.h
diff --git a/mojo/public/cpp/application/lib/service_connector_registry.h b/mojo/public/cpp/application/lib/service_connector_registry.h
deleted file mode 100644
index 235d34d5bd9a062a07b4bde1146546b7b3973282..0000000000000000000000000000000000000000
--- a/mojo/public/cpp/application/lib/service_connector_registry.h
+++ /dev/null
@@ -1,59 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef MOJO_PUBLIC_CPP_APPLICATION_LIB_SERVICE_CONNECTOR_REGISTRY_H_
-#define MOJO_PUBLIC_CPP_APPLICATION_LIB_SERVICE_CONNECTOR_REGISTRY_H_
-
-#include <map>
-#include <memory>
-#include <string>
-
-#include "mojo/public/cpp/system/message_pipe.h"
-
-namespace mojo {
-
-struct ConnectionContext;
-class ServiceConnector;
-
-namespace internal {
-
-// ServiceConnectorRegistry maintains a default ServiceConnector as well as at
-// most one ServiceConnector per interface name. When ConnectToService() is
-// invoked the ServiceConnector registered by name is given the request.
-class ServiceConnectorRegistry {
- public:
- ServiceConnectorRegistry();
- ~ServiceConnectorRegistry();
-
- // Returns true if non ServiceConnectors have been registered by name.
- bool empty() const { return name_to_service_connector_.empty(); }
-
- // Sets a ServiceConnector by name. This deletes any existing ServiceConnector
- // of the same name.
- void SetServiceConnectorForName(
- std::unique_ptr<ServiceConnector> service_connector,
- const std::string& interface_name);
- void RemoveServiceConnectorForName(const std::string& interface_name);
-
- // ConnectToService returns true if this registery has an entry for
- // |interface_name|. In that case, the |client_handle| is passed along
- // to the |ServiceConnector|. Otherwise, this function returns false and
- // |client_handle| is untouched.
- bool ConnectToService(const ConnectionContext& connection_context,
- const std::string& interface_name,
- ScopedMessagePipeHandle* client_handle);
-
- private:
- using NameToServiceConnectorMap =
- std::map<std::string, std::unique_ptr<ServiceConnector>>;
-
- NameToServiceConnectorMap name_to_service_connector_;
-
- MOJO_DISALLOW_COPY_AND_ASSIGN(ServiceConnectorRegistry);
-};
-
-} // namespace internal
-} // namespace mojo
-
-#endif // MOJO_PUBLIC_CPP_APPLICATION_LIB_SERVICE_CONNECTOR_REGISTRY_H_
« no previous file with comments | « mojo/public/cpp/application/BUILD.gn ('k') | mojo/public/cpp/application/lib/service_connector_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698