Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3874)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1983803002: Added notification when user presses backspace to use new shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@subtle-notification-view-refactor
Patch Set: Use UTF-16 instead of many UTF-8 conversions. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 9320f5a20243b05f67795d50987f1ebb5c30554d..bda804200668b926457b36198708d9fb316921a0 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -323,10 +323,14 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
case IDC_BACKSPACE_BACK:
if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
GoBack(browser_, disposition);
+ else
+ browser_->window()->ShowBackspaceNewShortcutBubble(false);
break;
case IDC_BACKSPACE_FORWARD:
if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
GoForward(browser_, disposition);
+ else
+ browser_->window()->ShowBackspaceNewShortcutBubble(true);
break;
case IDC_BACK:
GoBack(browser_, disposition);

Powered by Google App Engine
This is Rietveld 408576698