chrome/browser/ui/browser_command_controller.cc - Issue 1983803002: Added notification when user presses backspace to use new shortcut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1983803002: Added notification when user presses backspace to use new shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@subtle-notification-view-refactor

Patch Set: Use UTF-16 instead of many UTF-8 conversions. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index 9320f5a20243b05f67795d50987f1ebb5c30554d..bda804200668b926457b36198708d9fb316921a0 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -323,10 +323,14 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

case IDC_BACKSPACE_BACK:

if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))

GoBack(browser_, disposition);

+ else

+ browser_->window()->ShowBackspaceNewShortcutBubble(false);

break;

case IDC_BACKSPACE_FORWARD:

if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))

GoForward(browser_, disposition);

+ else

+ browser_->window()->ShowBackspaceNewShortcutBubble(true);

break;

case IDC_BACK:

GoBack(browser_, disposition);

« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | chrome/browser/ui/browser_window.h » ('j') | chrome/browser/ui/browser_window.h » ('J')