Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1983803002: Added notification when user presses backspace to use new shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@subtle-notification-view-refactor
Patch Set: Use UTF-16 instead of many UTF-8 conversions. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_command_controller.h" 5 #include "chrome/browser/ui/browser_command_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 return; 316 return;
317 } 317 }
318 318
319 // The order of commands in this switch statement must match the function 319 // The order of commands in this switch statement must match the function
320 // declaration order in browser.h! 320 // declaration order in browser.h!
321 switch (id) { 321 switch (id) {
322 // Navigation commands 322 // Navigation commands
323 case IDC_BACKSPACE_BACK: 323 case IDC_BACKSPACE_BACK:
324 if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature)) 324 if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
325 GoBack(browser_, disposition); 325 GoBack(browser_, disposition);
326 else
327 browser_->window()->ShowBackspaceNewShortcutBubble(false);
326 break; 328 break;
327 case IDC_BACKSPACE_FORWARD: 329 case IDC_BACKSPACE_FORWARD:
328 if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature)) 330 if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
329 GoForward(browser_, disposition); 331 GoForward(browser_, disposition);
332 else
333 browser_->window()->ShowBackspaceNewShortcutBubble(true);
330 break; 334 break;
331 case IDC_BACK: 335 case IDC_BACK:
332 GoBack(browser_, disposition); 336 GoBack(browser_, disposition);
333 break; 337 break;
334 case IDC_FORWARD: 338 case IDC_FORWARD:
335 GoForward(browser_, disposition); 339 GoForward(browser_, disposition);
336 break; 340 break;
337 case IDC_RELOAD: 341 case IDC_RELOAD:
338 Reload(browser_, disposition); 342 Reload(browser_, disposition);
339 break; 343 break;
(...skipping 928 matching lines...) Expand 10 before | Expand all | Expand 10 after
1268 1272
1269 BrowserWindow* BrowserCommandController::window() { 1273 BrowserWindow* BrowserCommandController::window() {
1270 return browser_->window(); 1274 return browser_->window();
1271 } 1275 }
1272 1276
1273 Profile* BrowserCommandController::profile() { 1277 Profile* BrowserCommandController::profile() {
1274 return browser_->profile(); 1278 return browser_->profile();
1275 } 1279 }
1276 1280
1277 } // namespace chrome 1281 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698