Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6439)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 1983803002: Added notification when user presses backspace to use new shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@subtle-notification-view-refactor
Patch Set: Use UTF-16 instead of many UTF-8 conversions. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 43837dd1013dc07308226ea54ae6d2868ad79aad..fdf92de8f8122a9f6a5fe0acc66e4a7562e36c1d 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -146,6 +146,10 @@ class BrowserWindow : public ui::BaseWindow {
// Returns true if the fullscreen bubble is visible.
virtual bool IsFullscreenBubbleVisible() const = 0;
+ // Shows a notice teaching the user the new shortcut for going Back (if
+ // |!forward|) or Forward (if |forward|).
Peter Kasting 2016/05/19 10:08:36 Nit: I'd remove the parentheticals, the function o
Matt Giuca 2016/05/23 04:22:56 Done.
+ virtual void ShowBackspaceNewShortcutBubble(bool forward) = 0;
Peter Kasting 2016/05/19 10:08:36 Nit: I would name this function, similar functions
Matt Giuca 2016/05/23 04:22:56 Done.
+
// Returns the size of WebContents in the browser. This may be called before
// the TabStripModel has an active tab.
virtual gfx::Size GetContentsSize() const = 0;

Powered by Google App Engine
This is Rietveld 408576698