Dart: Refactor Stubs

Dart: Refactor Stubs

This change refactors Stubs to be more similar to Proxies.
In particular, after this change, both FooStub and FooProxy
will implement the Foo interface.

After this change there are also more opportunities for
Stubs and Proxies to share interfaces, which will allow
both client and internal code to avoid using Object and
dynamic, and I'll pursue those in a follow up CL.

As with the change for Proxies, this is a breaking change
that will require indirection through the .ctrl field of
a Stub to manipulate the underlying MojoMessageHandler.
There are no other user-visible changes.

related #647

R=johnmccutchan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/48993a8a843ad4b7ee14c6cb42dd7f7497f25f20

[zra, 2016-05-13 22:42:04]

Description was changed from

==========
Dart: Refactor Stubs

related #647
==========

to

==========
Dart: Refactor Stubs

This change refactors Stubs to be more similar to Proxies.
In particular, after this change, both FooStub and FooProxy
will implement the Foo interface, and both fooProxy.ctrl and
fooStub.ctrl will implement the InterfaceControl interface.

These shared interfaces allow us to get rid of some
Object/dynamic types from the bindings, and should better
align the Dart bindings with the bindings for other
languages.

As with the change for Proxies, this is a breaking change
that will require indirection through the .ctrl field of
a Stub to manipulate the underlying MojoMessageHandler.
There should be no other user-visible changes.

related #647
==========

[zra, 2016-05-16 17:02:30]

Description was changed from

==========
Dart: Refactor Stubs

This change refactors Stubs to be more similar to Proxies.
In particular, after this change, both FooStub and FooProxy
will implement the Foo interface, and both fooProxy.ctrl and
fooStub.ctrl will implement the InterfaceControl interface.

These shared interfaces allow us to get rid of some
Object/dynamic types from the bindings, and should better
align the Dart bindings with the bindings for other
languages.

As with the change for Proxies, this is a breaking change
that will require indirection through the .ctrl field of
a Stub to manipulate the underlying MojoMessageHandler.
There should be no other user-visible changes.

related #647
==========

to

==========
Dart: Refactor Stubs

This change refactors Stubs to be more similar to Proxies.
In particular, after this change, both FooStub and FooProxy
will implement the Foo interface.

After this change there are also more opportunities for
Stubs and Proxies to share interfaces, which will allow
both client and internal code to avoid using Object and
dynamic, and I'll pursue those in a follow up CL.

As with the change for Proxies, this is a breaking change
that will require indirection through the .ctrl field of
a Stub to manipulate the underlying MojoMessageHandler.
There are no other user-visible changes.

related #647
==========

[zra, 2016-05-16 17:03:30]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-05-16 21:38:55]

LGTM with a breaking-change announcement

[zra, 2016-05-17 15:47:52]

Description was changed from

==========
Dart: Refactor Stubs

This change refactors Stubs to be more similar to Proxies.
In particular, after this change, both FooStub and FooProxy
will implement the Foo interface.

After this change there are also more opportunities for
Stubs and Proxies to share interfaces, which will allow
both client and internal code to avoid using Object and
dynamic, and I'll pursue those in a follow up CL.

As with the change for Proxies, this is a breaking change
that will require indirection through the .ctrl field of
a Stub to manipulate the underlying MojoMessageHandler.
There are no other user-visible changes.

related #647
==========

to

==========
Dart: Refactor Stubs

This change refactors Stubs to be more similar to Proxies.
In particular, after this change, both FooStub and FooProxy
will implement the Foo interface.

After this change there are also more opportunities for
Stubs and Proxies to share interfaces, which will allow
both client and internal code to avoid using Object and
dynamic, and I'll pursue those in a follow up CL.

As with the change for Proxies, this is a breaking change
that will require indirection through the .ctrl field of
a Stub to manipulate the underlying MojoMessageHandler.
There are no other user-visible changes.

related #647

R=johnmccutchan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/48993a8a843ad4b7ee14c6cb42d...
==========

[zra, 2016-05-17 15:47:54]

Committed patchset #6 (id:100001) manually as
48993a8a843ad4b7ee14c6cb42dd7f7497f25f20 (presubmit successful).