Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: mojo/dart/packages/mojo/lib/src/proxy.dart

Issue 1983453002: Dart: Refactor Stubs (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/packages/mojo/lib/src/control_message.dart ('k') | mojo/dart/packages/mojo/lib/src/stub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/packages/mojo/lib/src/proxy.dart
diff --git a/mojo/dart/packages/mojo/lib/src/proxy.dart b/mojo/dart/packages/mojo/lib/src/proxy.dart
index d1d6c0b15800f7238f819169125c3b8d60b1a253..ea1afac78a98a492831e43febe7ea45ec8482283 100644
--- a/mojo/dart/packages/mojo/lib/src/proxy.dart
+++ b/mojo/dart/packages/mojo/lib/src/proxy.dart
@@ -44,14 +44,14 @@ class Proxy {
/// Generated Proxy classes have a factory Proxy.connectToService which takes
/// a ServiceConnector, a url, and optionally a service name and returns a
/// bound Proxy. For example, every class extending the Application base class
-/// in package:mojo/application.dart inherits and implementation of the
+/// in package:mojo/application.dart inherits an implementation of the
/// ServiceConnector interface.
abstract class ServiceConnector {
/// Connects [proxy] to the service called [serviceName] that lives at [url].
void connectToService(String url, Proxy proxy, [String serviceName]);
}
-class ProxyMessageHandler extends core.MojoEventHandler {
+abstract class ProxyMessageHandler extends core.MojoEventHandler {
HashMap<int, Completer> _completerMap = new HashMap<int, Completer>();
Completer _errorCompleter = new Completer();
Set<Completer> _errorCompleters;
@@ -70,7 +70,7 @@ class ProxyMessageHandler extends core.MojoEventHandler {
/// The function that handles responses to sent proxy message. It should be
/// implemented by the generated ProxyControl classes that extend
/// [ProxyMessageHandler].
- void handleResponse(ServiceMessage msg) {}
+ void handleResponse(ServiceMessage msg);
/// If there is an error in using this proxy, this future completes with
/// a ProxyError.
@@ -173,6 +173,7 @@ class ProxyMessageHandler extends core.MojoEventHandler {
// Need a getter for this for access in subclasses.
HashMap<int, Completer> get completerMap => _completerMap;
+ @override
String toString() {
var superString = super.toString();
return "ProxyMessageHandler(${superString})";
« no previous file with comments | « mojo/dart/packages/mojo/lib/src/control_message.dart ('k') | mojo/dart/packages/mojo/lib/src/stub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698