Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1983383002: Convert IntersectionObserver tests to use testRunner.runIdleTasks. (Closed)

Created:
4 years, 7 months ago by szager1
Modified:
4 years, 7 months ago
Reviewers:
Sami, ojan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert IntersectionObserver tests to use testRunner.runIdleTasks. BUG=606491 R=ojan@chromium.org,skyostil@chromium.org Committed: https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a Cr-Commit-Position: refs/heads/master@{#394711}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move helper-functions.js into resources #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -226 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html View 1 2 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/helper-functions.js View 1 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/containing-block.html View 1 5 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/edge-inclusive-intersection.html View 1 3 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/helper-functions.js View 1 1 chunk +0 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html View 1 3 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/multiple-thresholds.html View 1 9 chunks +10 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/observer-without-js-reference.html View 1 2 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/remove-element.html View 1 4 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/root-margin.html View 1 3 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html View 1 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html View 1 4 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html View 1 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/timestamp.html View 1 5 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/timestamp-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html View 1 2 chunks +3 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/resources/intersection-observer-helper-functions.js View 1 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
szager1
4 years, 7 months ago (2016-05-18 00:10:44 UTC) #1
Sami
lgtm (thanks for the great comment too.) https://codereview.chromium.org/1983383002/diff/1/third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html File third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html (right): https://codereview.chromium.org/1983383002/diff/1/third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html#newcode20 third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html:20: }) nit: ...
4 years, 7 months ago (2016-05-18 10:07:23 UTC) #2
szager1
https://codereview.chromium.org/1983383002/diff/1/third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html File third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html (right): https://codereview.chromium.org/1983383002/diff/1/third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html#newcode20 third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html:20: }) On 2016/05/18 10:07:23, Sami wrote: > nit: missing ...
4 years, 7 months ago (2016-05-18 21:25:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983383002/20001
4 years, 7 months ago (2016-05-19 05:32:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/186218)
4 years, 7 months ago (2016-05-19 05:42:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983383002/40001
4 years, 7 months ago (2016-05-19 06:31:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 08:06:52 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 08:08:22 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/923374c640e686109bf0bbfe917fa95f66f0d00a
Cr-Commit-Position: refs/heads/master@{#394711}

Powered by Google App Engine
This is Rietveld 408576698