third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html - Issue 1983383002: Convert IntersectionObserver tests to use testRunner.runIdleTasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html

Issue 1983383002: Convert IntersectionObserver tests to use testRunner.runIdleTasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/timestamp-expected.txt ('k') | third_party/WebKit/LayoutTests/resources/intersection-observer-helper-functions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html

diff --git a/third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html b/third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html

index 2bb0c81f770ce185dc3840dd1e094648baa08ffa..c11ae11ee565e5d6642f9580e35b6aa9a0ccf768 100644

--- a/third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html

+++ b/third_party/WebKit/LayoutTests/intersection-observer/unclipped-root.html

@@ -1,6 +1,6 @@

<!DOCTYPE html>

-<script src="helper-functions.js"></script>

+<script src="../resources/intersection-observer-helper-functions.js"></script>

<style>

#root {

overflow: visible;

@@ -32,19 +32,16 @@ onload = function() {

observer.observe(target);

entries.push(...observer.takeRecords());

shouldBeEqualToNumber("entries.length", 0);

- // See README for explanation of double RAF.

- requestAnimationFrame(() => { requestAnimationFrame(step0) });

+ waitForNotification(step0);

}

function step0() {

- entries.push(...observer.takeRecords());

shouldBeEqualToNumber("entries.length", 0);

target.style.transform = "translateY(195px)";

- requestAnimationFrame(step1);

+ waitForNotification(step1);

}

function step1() {

- entries.push(...observer.takeRecords());

shouldBeEqualToNumber("entries.length", 1);

if (entries.length > 0) {

shouldBeEqualToNumber("entries[0].boundingClientRect.left", 15);