third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html - Issue 1983383002: Convert IntersectionObserver tests to use testRunner.runIdleTasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html

Issue 1983383002: Convert IntersectionObserver tests to use testRunner.runIdleTasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/helper-functions.js ('k') | third_party/WebKit/LayoutTests/intersection-observer/multiple-thresholds.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html

diff --git a/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html b/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html

index 134b6455d55259481cf48160abac7b590c00b899..48a735f05fb3797cbc538bb71b9fb9d979dd2835 100644

--- a/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html

+++ b/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html

@@ -1,6 +1,6 @@

<!DOCTYPE html>

-<script src="helper-functions.js"></script>

+<script src="../resources/intersection-observer-helper-functions.js"></script>

@@ -19,26 +19,22 @@ targetIframe.onload = function() {

observer.observe(target);

entries = entries.concat(observer.takeRecords());

shouldBeEqualToNumber("entries.length", 0);

- // See README for explanation of double RAF.

- requestAnimationFrame(() => { requestAnimationFrame(step0) });

+ waitForNotification(step0);

}

function step0() {

- entries = entries.concat(observer.takeRecords());

shouldBeEqualToNumber("entries.length", 0);

document.scrollingElement.scrollTop = 200;

- requestAnimationFrame(step1);

+ waitForNotification(step1);

}

function step1() {

- entries = entries.concat(observer.takeRecords());

shouldBeEqualToNumber("entries.length", 0);

iframeScroller.scrollTop = 250;

- requestAnimationFrame(step2);

+ waitForNotification(step2);

}

function step2() {

- entries = entries.concat(observer.takeRecords());

shouldBeEqualToNumber("entries.length", 1);

if (entries.length > 0) {

shouldBeEqualToNumber("entries[0].boundingClientRect.left", 8);

@@ -56,11 +52,10 @@ function step2() {

shouldEvaluateToSameObject("entries[0].target", target);

}

document.scrollingElement.scrollTop = 100;

- requestAnimationFrame(step3);

+ waitForNotification(step3);

}

function step3() {

- entries = entries.concat(observer.takeRecords());

shouldBeEqualToNumber("entries.length", 2);

if (entries.length > 1) {

shouldBeEqualToNumber("entries[1].boundingClientRect.left", 8);