Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1983333002: Define SYS_NATIVE_UTF8 for base_unittests on Chromecast (Closed)

Created:
4 years, 7 months ago by halliwell
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, slan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define SYS_NATIVE_UTF8 for base_unittests on Chromecast This define was originally added in gyp: https://codereview.chromium.org/987943002 and then added to gn build here, but missed the tests target: https://codereview.chromium.org/1856333003 BUG=internal b/28801950 Committed: https://crrev.com/50ea9184f03caf35d100bf9d758c5702fa320040 Cr-Commit-Position: refs/heads/master@{#394320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
halliwell
4 years, 7 months ago (2016-05-17 22:45:10 UTC) #3
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-18 01:00:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983333002/1
4 years, 7 months ago (2016-05-18 01:14:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 03:20:05 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 03:21:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50ea9184f03caf35d100bf9d758c5702fa320040
Cr-Commit-Position: refs/heads/master@{#394320}

Powered by Google App Engine
This is Rietveld 408576698