Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 1856333003: [Chromecast] Define SYSTEM_NATIVE_UTF8 for Chromecast builds. (Closed)

Created:
4 years, 8 months ago by slan
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, halliwell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Define SYSTEM_NATIVE_UTF8 for Chromecast builds. This was added to the GYP build about a year ago, a change which predated Chromecast's support for GN: https://codereview.chromium.org/987943002 I suspect that this will resolve many of the failures we're seeing on devices and on the builder: b/27722323. In any case, it gets us parity with the GYP build. BUG= internal b/27722323 Committed: https://crrev.com/a0f888d71211adced0275927a8bb666cbf5534d4 Cr-Commit-Position: refs/heads/master@{#385382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856333003/1
4 years, 8 months ago (2016-04-06 00:56:47 UTC) #2
slan
PTAL!
4 years, 8 months ago (2016-04-06 00:56:54 UTC) #4
Lei Zhang
lgtm Doh, how did me from a year ago miss that?
4 years, 8 months ago (2016-04-06 01:03:51 UTC) #5
slan
On 2016/04/06 01:03:51, Lei Zhang wrote: > lgtm > > Doh, how did me from ...
4 years, 8 months ago (2016-04-06 01:23:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 01:35:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856333003/1
4 years, 8 months ago (2016-04-06 04:13:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 04:18:24 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 04:19:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0f888d71211adced0275927a8bb666cbf5534d4
Cr-Commit-Position: refs/heads/master@{#385382}

Powered by Google App Engine
This is Rietveld 408576698