Add best-effort/allow rollback flags on WorkItem.

Add best-effort/allow rollback flags on WorkItem.

When the best-effort flag is set to true, Do() always return true
(i.e. it will never cause failure of its parent WorkItemList).

When the enable rollback flag is set to false, Rollback() is a
no-op.

This CL is identical to the reverted CL
https://codereview.chromium.org/1882923003/ modulo a fix not to
break official builds.

BUG=601936
Committed: https://crrev.com/a5f09ba5c1e42487724bf62b9f25186b3e76c69d
Cr-Commit-Position: refs/heads/master@{#394396}

[fdoray, 2016-05-16 17:27:55]

Description was changed from

==========
Add best-effort/allow rollback flags on WorkItem.

When the best-effort flag is set to true, Do() always return true
(i.e. it will never cause failure of its parent WorkItemList).

When the allow rollback flag is set to false, Rollback() is a no-op.

BUG=601936
==========

to

==========
Add best-effort/allow rollback flags on WorkItem.

When the best-effort flag is set to true, Do() always return true
(i.e. it will never cause failure of its parent WorkItemList).

When the enable rollback flag is set to false, Rollback() is a
no-op.

This CL is identical to the reverted CL
https://codereview.chromium.org/1882923003/ modulo a fix not to
break official builds.

BUG=601936
==========

[fdoray, 2016-05-16 17:33:42]

fdoray@chromium.org changed reviewers:
+ grt@chromium.org

[fdoray, 2016-05-16 17:33:43]

Can you review this CL? Thanks.

[grt (UTC plus 2), 2016-05-16 18:55:01]

https://codereview.chromium.org/1982653002/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/app_launcher_installer.h (left):

https://codereview.chromium.org/1982653002/diff/20001/chrome/installer/setup/...
chrome/installer/setup/app_launcher_installer.h:14: #if
defined(GOOGLE_CHROME_BUILD)
why remove this?

https://codereview.chromium.org/1982653002/diff/20001/chrome/installer/setup/...
chrome/installer/setup/app_launcher_installer.h:32: void
AddAppLauncherVersionKeyWorkItems(
why mix the WI refactor with removing this code?

[fdoray, 2016-05-17 17:18:48]

PTAnL

https://codereview.chromium.org/1982653002/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/app_launcher_installer.h (left):

https://codereview.chromium.org/1982653002/diff/20001/chrome/installer/setup/...
chrome/installer/setup/app_launcher_installer.h:14: #if
defined(GOOGLE_CHROME_BUILD)
On 2016/05/16 18:55:01, grt (slow) wrote:
> why remove this?

To catch build errors before code reaches internal builders.

https://codereview.chromium.org/1982653002/diff/20001/chrome/installer/setup/...
chrome/installer/setup/app_launcher_installer.h:32: void
AddAppLauncherVersionKeyWorkItems(
On 2016/05/16 18:55:01, grt (slow) wrote:
> why mix the WI refactor with removing this code?

created a separate CL https://codereview.chromium.org/1988683003/

[fdoray, 2016-05-17 18:40:22]

PTAnL

[grt (UTC plus 2), 2016-05-18 02:40:26]

lgtm

[fdoray, 2016-05-18 12:00:26]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-05-18 12:00:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982653002/60001

[commit-bot: I haz the power, 2016-05-18 13:08:45]

Description was changed from

==========
Add best-effort/allow rollback flags on WorkItem.

When the best-effort flag is set to true, Do() always return true
(i.e. it will never cause failure of its parent WorkItemList).

When the enable rollback flag is set to false, Rollback() is a
no-op.

This CL is identical to the reverted CL
https://codereview.chromium.org/1882923003/ modulo a fix not to
break official builds.

BUG=601936
==========

to

==========
Add best-effort/allow rollback flags on WorkItem.

When the best-effort flag is set to true, Do() always return true
(i.e. it will never cause failure of its parent WorkItemList).

When the enable rollback flag is set to false, Rollback() is a
no-op.

This CL is identical to the reverted CL
https://codereview.chromium.org/1882923003/ modulo a fix not to
break official builds.

BUG=601936
==========

[commit-bot: I haz the power, 2016-05-18 13:08:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-18 13:10:03]

Description was changed from

==========
Add best-effort/allow rollback flags on WorkItem.

When the best-effort flag is set to true, Do() always return true
(i.e. it will never cause failure of its parent WorkItemList).

When the enable rollback flag is set to false, Rollback() is a
no-op.

This CL is identical to the reverted CL
https://codereview.chromium.org/1882923003/ modulo a fix not to
break official builds.

BUG=601936
==========

to

==========
Add best-effort/allow rollback flags on WorkItem.

When the best-effort flag is set to true, Do() always return true
(i.e. it will never cause failure of its parent WorkItemList).

When the enable rollback flag is set to false, Rollback() is a
no-op.

This CL is identical to the reverted CL
https://codereview.chromium.org/1882923003/ modulo a fix not to
break official builds.

BUG=601936

Committed: https://crrev.com/a5f09ba5c1e42487724bf62b9f25186b3e76c69d
Cr-Commit-Position: refs/heads/master@{#394396}
==========

[commit-bot: I haz the power, 2016-05-18 13:10:04]

Patchset 4 (id:??) landed as
https://crrev.com/a5f09ba5c1e42487724bf62b9f25186b3e76c69d
Cr-Commit-Position: refs/heads/master@{#394396}