chrome/installer/setup/setup_main.cc - Issue 1982653002: Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 1982653002: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't remove code from app_launcher_installer.cc Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/setup_main.cc

diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc

index 2e5d289709a69dad8faa7a34a493a3b70a1bcb2a..69efa0fbd4f6208adeec2cf14c633736b08a2c18 100644

--- a/chrome/installer/setup/setup_main.cc

+++ b/chrome/installer/setup/setup_main.cc

@@ -430,10 +430,8 @@ installer::InstallStatus RenameChromeExecutables(

google_update::kRegRenameCmdField);

}

// old_chrome.exe is still in use in most cases, so ignore failures here.

- // Make sure this is the last item in the list because it cannot be rolled

- // back.

- install_list->AddDeleteTreeWorkItem(chrome_old_exe, temp_path.path())->

- set_ignore_failure(true);

+ install_list->AddDeleteTreeWorkItem(chrome_old_exe, temp_path.path())

+ ->set_best_effort(true);

installer::InstallStatus ret = installer::RENAME_SUCCESSFUL;

if (!install_list->Do()) {