chrome/installer/util/create_reg_key_work_item.cc - Issue 1982653002: Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/create_reg_key_work_item.cc

Issue 1982653002: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't remove code from app_launcher_installer.cc Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/create_reg_key_work_item.cc

diff --git a/chrome/installer/util/create_reg_key_work_item.cc b/chrome/installer/util/create_reg_key_work_item.cc

index 431963146284d1cffd172bc4e3f4bbbf2fe0f302..dbf46b2058dd9399282c3a029667e0c9e1b8503e 100644

--- a/chrome/installer/util/create_reg_key_work_item.cc

+++ b/chrome/installer/util/create_reg_key_work_item.cc

@@ -46,7 +46,7 @@ CreateRegKeyWorkItem::CreateRegKeyWorkItem(HKEY predefined_root,

wow64_access == KEY_WOW64_64KEY);

}

-bool CreateRegKeyWorkItem::Do() {

+bool CreateRegKeyWorkItem::DoImpl() {

if (!InitKeyList()) {

// Nothing needs to be done here.

VLOG(1) << "no key to create";

@@ -90,7 +90,7 @@ bool CreateRegKeyWorkItem::Do() {

return true;

}

-void CreateRegKeyWorkItem::Rollback() {

+void CreateRegKeyWorkItem::RollbackImpl() {

if (!key_created_)

return;