Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1982493002: [Android] Log uncaught Java exceptions when running native tests. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Log uncaught Java exceptions when running native tests. Currently, Java exceptions hit while running native tests -- e.g. on JNI link failure -- are lost to the logcat. This surfaces them to the test runner's stdout. BUG= Committed: https://crrev.com/6cdb933c8d2c4cadbf842fbb3ceb9cecd0f70920 Cr-Commit-Position: refs/heads/master@{#393921}

Patch Set 1 #

Patch Set 2 : prereview cleaning #

Patch Set 3 : fix findbugs warning #

Messages

Total messages: 14 (6 generated)
jbudorick
Hitting this a bunch while working on browser_tests.
4 years, 7 months ago (2016-05-14 00:48:05 UTC) #2
Ted C
lgtm
4 years, 7 months ago (2016-05-16 16:54:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982493002/10007 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982493002/10007
4 years, 7 months ago (2016-05-16 16:55:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/66735)
4 years, 7 months ago (2016-05-16 17:44:10 UTC) #7
jbudorick
On 2016/05/16 17:44:10, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-16 19:10:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982493002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982493002/30001
4 years, 7 months ago (2016-05-16 19:29:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 7 months ago (2016-05-16 21:12:03 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:14:24 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6cdb933c8d2c4cadbf842fbb3ceb9cecd0f70920
Cr-Commit-Position: refs/heads/master@{#393921}

Powered by Google App Engine
This is Rietveld 408576698