Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 1982493002: [Android] Log uncaught Java exceptions when running native tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs warning Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/local/device/local_device_gtest_run.py
diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py
index 8b0d1a3e45bab00492804aace72f37aaf20b6c21..2630af9e37a04cb25fd692ac3e8b8b455c9847f3 100644
--- a/build/android/pylib/local/device/local_device_gtest_run.py
+++ b/build/android/pylib/local/device/local_device_gtest_run.py
@@ -4,6 +4,7 @@
import collections
import itertools
+import logging
import os
import posixpath
@@ -311,9 +312,13 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):
@local_device_test_run.handle_shard_failures_with(
on_failure=self._env.BlacklistDevice)
def list_tests(dev):
- tests = self._delegate.Run(
+ raw_test_list = self._delegate.Run(
None, dev, flags='--gtest_list_tests', timeout=30)
- tests = gtest_test_instance.ParseGTestListTests(tests)
+ tests = gtest_test_instance.ParseGTestListTests(raw_test_list)
+ if not tests:
+ logging.info('No tests found. Output:')
+ for l in raw_test_list:
+ logging.info(' %s', l)
tests = self._test_instance.FilterTests(tests)
return tests
« no previous file with comments | « no previous file | testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698