testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java - Issue 1982493002: [Android] Log uncaught Java exceptions when running native tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java

Issue 1982493002: [Android] Log uncaught Java exceptions when running native tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix findbugs warning Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java ('k') | testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReporter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java

diff --git a/testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java b/testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java

index f0a0d7e4a86a17090854e7943e81a847cb1e63bb..e18efa8afc04815c917ae010a9290569424d6e1e 100644

--- a/testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java

+++ b/testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java

@@ -37,6 +37,7 @@ public class TestStatusReceiver extends BroadcastReceiver {

filter.addAction(TestStatusReporter.ACTION_TEST_STARTED);

filter.addAction(TestStatusReporter.ACTION_TEST_RUN_STARTED);

filter.addAction(TestStatusReporter.ACTION_TEST_RUN_FINISHED);

+ filter.addAction(TestStatusReporter.ACTION_UNCAUGHT_EXCEPTION);

try {

filter.addDataType(TestStatusReporter.DATA_TYPE_HEARTBEAT);

filter.addDataType(TestStatusReporter.DATA_TYPE_RESULT);

@@ -70,6 +71,7 @@ public class TestStatusReceiver extends BroadcastReceiver {

public interface TestRunCallback {

void testRunStarted(int pid);

void testRunFinished(int pid);

+ void uncaughtException(int pid, String stackTrace);

}

/** Register a callback for when a test has failed. */

@@ -145,6 +147,11 @@ public class TestStatusReceiver extends BroadcastReceiver {

c.testRunFinished(pid);

}

break;

+ case TestStatusReporter.ACTION_UNCAUGHT_EXCEPTION:

+ for (TestRunCallback c: mTestRunCallbacks) {

+ c.uncaughtException(pid, stackTrace);

+ }

+ break;

default:

Log.e(TAG, "Unrecognized intent received: %s", intent.toString());

break;