Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1980483002: [wasm] Remove legacy encoding of local variables from asm->wasm. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove legacy encoding of local variables from asm->wasm. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/82db9dece3e6e7352f8a68fc92cb511f8f08eeb0 Cr-Commit-Position: refs/heads/master@{#36239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -101 lines) Patch
M src/wasm/module-decoder.cc View 4 chunks +1 line, -18 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/wasm/test-wasm-function-name-table.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 5 chunks +11 lines, -66 lines 0 comments Download

Dependent Patchsets:

Issue 1980543002 Patch 1
Issue 1980543002 Patch 20001
Issue 1980543002 Patch 40001

Messages

Total messages: 7 (2 generated)
titzer
4 years, 7 months ago (2016-05-13 12:19:04 UTC) #1
ahaas
lgtm
4 years, 7 months ago (2016-05-13 12:30:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980483002/1
4 years, 7 months ago (2016-05-13 12:35:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 12:47:54 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 12:49:45 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/82db9dece3e6e7352f8a68fc92cb511f8f08eeb0
Cr-Commit-Position: refs/heads/master@{#36239}

Powered by Google App Engine
This is Rietveld 408576698