Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1980543002: [wasm] Remove renumbering of local variables from asm->wasm. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@wasm_renumber
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove renumbering of local variables from asm->wasm. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/f93066b3afbf5eed49f7b30ede9b50f46064f168 Cr-Commit-Position: refs/heads/master@{#36292}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix memory leak by using a zone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -387 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 2 15 chunks +44 lines, -28 lines 0 comments Download
M src/wasm/encoder.h View 1 8 chunks +13 lines, -25 lines 0 comments Download
M src/wasm/encoder.cc View 1 2 8 chunks +20 lines, -175 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 2 4 chunks +18 lines, -9 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 9 chunks +31 lines, -12 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M test/unittests/wasm/encoder-unittest.cc View 2 chunks +2 lines, -135 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
titzer
4 years, 7 months ago (2016-05-13 15:04:35 UTC) #1
bradnelson
lgtm
4 years, 7 months ago (2016-05-13 17:30:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980543002/20001
4 years, 7 months ago (2016-05-13 17:30:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/1648) v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-13 18:00:56 UTC) #6
titzer
On 2016/05/13 18:00:56, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-17 07:38:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980543002/40001
4 years, 7 months ago (2016-05-17 17:52:12 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 17:53:57 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 17:57:50 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f93066b3afbf5eed49f7b30ede9b50f46064f168
Cr-Commit-Position: refs/heads/master@{#36292}

Powered by Google App Engine
This is Rietveld 408576698