Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: src/wasm/module-decoder.cc

Issue 1980483002: [wasm] Remove legacy encoding of local variables from asm->wasm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/wasm-module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/module-decoder.cc
diff --git a/src/wasm/module-decoder.cc b/src/wasm/module-decoder.cc
index a95a13b961acc90255a63d8dda1ffa7f8c3e4dad..f7d26a5f85645835a23965d52e4cc45db8bd9f3e 100644
--- a/src/wasm/module-decoder.cc
+++ b/src/wasm/module-decoder.cc
@@ -172,10 +172,6 @@ class ModuleDecoder : public Decoder {
0, // name_length
0, // code_start_offset
0, // code_end_offset
- 0, // local_i32_count
- 0, // local_i64_count
- 0, // local_f32_count
- 0, // local_f64_count
false}); // exported
WasmFunction* function = &module->functions.back();
function->sig_index = consume_sig_index(module, &function->sig);
@@ -230,10 +226,6 @@ class ModuleDecoder : public Decoder {
0, // name_length
0, // code_start_offset
0, // code_end_offset
- 0, // local_i32_count
- 0, // local_i64_count
- 0, // local_f32_count
- 0, // local_f64_count
false}); // exported
WasmFunction* function = &module->functions.back();
DecodeFunctionInModule(module, function, false);
@@ -519,10 +511,8 @@ class ModuleDecoder : public Decoder {
function->sig = module->signatures[function->sig_index];
}
- TRACE(" +%d <function attributes:%s%s%s>\n",
- static_cast<int>(pc_ - start_),
+ TRACE(" +%d <function attributes:%s%s>\n", static_cast<int>(pc_ - start_),
decl_bits & kDeclFunctionName ? " name" : "",
- decl_bits & kDeclFunctionLocals ? " locals" : "",
decl_bits & kDeclFunctionExport ? " exported" : "");
function->exported = decl_bits & kDeclFunctionExport;
@@ -532,13 +522,6 @@ class ModuleDecoder : public Decoder {
consume_string(&function->name_length, function->exported);
}
- if (decl_bits & kDeclFunctionLocals) {
- function->local_i32_count = consume_u16("i32 count");
- function->local_i64_count = consume_u16("i64 count");
- function->local_f32_count = consume_u16("f32 count");
- function->local_f64_count = consume_u16("f64 count");
- }
-
uint16_t size = consume_u16("body size");
if (ok()) {
if ((pc_ + size) > limit_) {
« no previous file with comments | « no previous file | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698