Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1980063002: Inject synthetic key events later in the input pipeline. (Closed)

Created:
4 years, 7 months ago by Jamie
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Inject synthetic key events later in the input pipeline. There is already a comment in the code explaining that this is to ensure that they are not mapped or trapped, but https://codereview.chromium.org/1760633003 reordered the pipeline so that it was no longer correct. As a result, the Alt+Delete -> Alt+Backspace mapping in the normalizing input filter for ChromeOS was triggering. BUG=611251 Review-Url: https://codereview.chromium.org/1973413004 Cr-Commit-Position: refs/heads/master@{#393715} (cherry picked from commit b221cf7b2a66075467ce1184d68bac0e0b0e7614) Committed: https://chromium.googlesource.com/chromium/src/+/bd019e9b426a2414a98706531463701b3b85225b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Jamie
4 years, 7 months ago (2016-05-16 16:48:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd019e9b426a2414a98706531463701b3b85225b.

Powered by Google App Engine
This is Rietveld 408576698