Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1973413004: Inject synthetic key events later in the input pipeline. (Closed)

Created:
4 years, 7 months ago by Jamie
Modified:
4 years, 7 months ago
Reviewers:
Sergey Ulanov, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inject synthetic key events later in the input pipeline. There is already a comment in the code explaining that this is to ensure that they are not mapped or trapped, but https://codereview.chromium.org/1760633003 reordered the pipeline so that it was no longer correct. As a result, the Alt+Delete -> Alt+Backspace mapping in the normalizing input filter for ChromeOS was triggering. BUG=611251 Committed: https://crrev.com/b221cf7b2a66075467ce1184d68bac0e0b0e7614 Cr-Commit-Position: refs/heads/master@{#393715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Jamie
ptal
4 years, 7 months ago (2016-05-13 23:31:34 UTC) #2
garykac
lgtm
4 years, 7 months ago (2016-05-14 00:25:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973413004/1
4 years, 7 months ago (2016-05-14 00:26:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-14 01:02:23 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b221cf7b2a66075467ce1184d68bac0e0b0e7614 Cr-Commit-Position: refs/heads/master@{#393715}
4 years, 7 months ago (2016-05-14 01:03:28 UTC) #11
Sergey Ulanov
4 years, 7 months ago (2016-05-14 05:32:33 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698