Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1760633003: Notify normalizing input filters on blur. (Closed)

Created:
4 years, 9 months ago by Jamie
Modified:
4 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify normalizing input filters on blur. Previously, ReleaseAllKeys was not notifying the normalizing input filter because that filter exists above InputEventTracker in the input pipeline. In fact, the input "pipeline" was more like a tree, with both the touch input scaler and the pepper input handler feeding into the input tracker. This CL establishes a linear pipeline, as described in the header comment. BUG=590404 Committed: https://crrev.com/14ece3d4e77348d546b4d6837704f78ab0068e31 Cr-Commit-Position: refs/heads/master@{#379398}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Review feedback. #

Patch Set 3 : Rebase #

Patch Set 4 : Fix host build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -36 lines) Patch
M remoting/client/plugin/chromoting_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 3 chunks +3 lines, -10 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.cc View 8 chunks +6 lines, -17 lines 0 comments Download
M remoting/protocol/input_event_tracker.h View 1 2 3 2 chunks +8 lines, -3 lines 0 comments Download
M remoting/protocol/input_event_tracker.cc View 1 2 3 5 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Jamie
ptal https://codereview.chromium.org/1760633003/diff/1/remoting/protocol/input_event_tracker.cc File remoting/protocol/input_event_tracker.cc (right): https://codereview.chromium.org/1760633003/diff/1/remoting/protocol/input_event_tracker.cc#newcode25 remoting/protocol/input_event_tracker.cc:25: DCHECK(input_stub_); Note that this is different from the ...
4 years, 9 months ago (2016-03-03 00:18:54 UTC) #2
Sergey Ulanov
lgtm https://codereview.chromium.org/1760633003/diff/1/remoting/protocol/input_event_tracker.h File remoting/protocol/input_event_tracker.h (right): https://codereview.chromium.org/1760633003/diff/1/remoting/protocol/input_event_tracker.h#newcode29 remoting/protocol/input_event_tracker.h:29: void set_input_stub(protocol::InputStub* input_stub) { don't need protocol:: https://codereview.chromium.org/1760633003/diff/1/remoting/protocol/input_event_tracker.h#newcode56 ...
4 years, 9 months ago (2016-03-04 00:30:45 UTC) #3
Jamie
FYI https://codereview.chromium.org/1760633003/diff/1/remoting/protocol/input_event_tracker.h File remoting/protocol/input_event_tracker.h (right): https://codereview.chromium.org/1760633003/diff/1/remoting/protocol/input_event_tracker.h#newcode29 remoting/protocol/input_event_tracker.h:29: void set_input_stub(protocol::InputStub* input_stub) { On 2016/03/04 00:30:45, Sergey ...
4 years, 9 months ago (2016-03-04 01:39:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760633003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760633003/40001
4 years, 9 months ago (2016-03-04 01:39:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/102566) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-04 02:05:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760633003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760633003/60001
4 years, 9 months ago (2016-03-04 22:54:56 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-04 23:46:24 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 23:48:00 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/14ece3d4e77348d546b4d6837704f78ab0068e31
Cr-Commit-Position: refs/heads/master@{#379398}

Powered by Google App Engine
This is Rietveld 408576698