Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1979953002: Remove OwnPtr::release() calls in modules/ (part 3). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
tzik, blink-reviews, chromium-reviews, falken, hongchan, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, Raymond Toy, serviceworker-reviews, toyoshim+midi_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in modules/ (part 3). OwnPtr::release() calls can be (1) replaced with std::move(), or (2) removed entirely (in certain "return" statements). BUG=611660 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc Cr-Commit-Position: refs/heads/master@{#393806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979953002/1
4 years, 7 months ago (2016-05-16 06:07:33 UTC) #3
Yuta Kitamura
tzik: PTAL? +haraken for modules/ approval.
4 years, 7 months ago (2016-05-16 06:09:03 UTC) #6
tzik
lgtm
4 years, 7 months ago (2016-05-16 06:11:13 UTC) #7
haraken
LGTM
4 years, 7 months ago (2016-05-16 06:27:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 07:38:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979953002/1
4 years, 7 months ago (2016-05-16 07:44:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 07:48:49 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 07:51:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc
Cr-Commit-Position: refs/heads/master@{#393806}

Powered by Google App Engine
This is Rietveld 408576698