Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/Database.cpp

Issue 1979953002: Remove OwnPtr::release() calls in modules/ (part 3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/Database.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/Database.cpp b/third_party/WebKit/Source/modules/webdatabase/Database.cpp
index 2a4302f48f40ff34e01c7329aad8146c84d44476..395f746bd35c4a2f467a123c00cde95abe90be42 100644
--- a/third_party/WebKit/Source/modules/webdatabase/Database.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/Database.cpp
@@ -266,7 +266,7 @@ bool Database::openAndVerifyVersion(bool setVersionInNewDatabase, DatabaseError&
DatabaseTracker::tracker().prepareToOpenDatabase(this);
bool success = false;
OwnPtr<DatabaseOpenTask> task = DatabaseOpenTask::create(this, setVersionInNewDatabase, &synchronizer, error, errorMessage, success);
- getDatabaseContext()->databaseThread()->scheduleTask(task.release());
+ getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
synchronizer.waitForTaskCompletion();
return success;
@@ -334,7 +334,7 @@ void Database::scheduleTransaction()
OwnPtr<DatabaseTransactionTask> task = DatabaseTransactionTask::create(transaction);
WTF_LOG(StorageAPI, "Scheduling DatabaseTransactionTask %p for transaction %p\n", task.get(), task->transaction());
m_transactionInProgress = true;
- getDatabaseContext()->databaseThread()->scheduleTask(task.release());
+ getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
} else {
m_transactionInProgress = false;
}
@@ -347,7 +347,7 @@ void Database::scheduleTransactionStep(SQLTransactionBackend* transaction)
OwnPtr<DatabaseTransactionTask> task = DatabaseTransactionTask::create(transaction);
WTF_LOG(StorageAPI, "Scheduling DatabaseTransactionTask %p for the transaction step\n", task.get());
- getDatabaseContext()->databaseThread()->scheduleTask(task.release());
+ getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
}
SQLTransactionClient* Database::transactionClient() const
@@ -836,7 +836,7 @@ void Database::runTransaction(
ASSERT(callback == originalErrorCallback);
if (callback) {
OwnPtr<SQLErrorData> error = SQLErrorData::create(SQLError::UNKNOWN_ERR, "database has been closed");
- getExecutionContext()->postTask(BLINK_FROM_HERE, createSameThreadTask(&callTransactionErrorCallback, callback, passed(error.release())));
+ getExecutionContext()->postTask(BLINK_FROM_HERE, createSameThreadTask(&callTransactionErrorCallback, callback, passed(std::move(error))));
}
}
}
@@ -888,7 +888,7 @@ Vector<String> Database::tableNames()
return result;
OwnPtr<DatabaseTableNamesTask> task = DatabaseTableNamesTask::create(this, &synchronizer, result);
- getDatabaseContext()->databaseThread()->scheduleTask(task.release());
+ getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
synchronizer.waitForTaskCompletion();
return result;

Powered by Google App Engine
This is Rietveld 408576698