third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp - Issue 1979953002: Remove OwnPtr::release() calls in modules/ (part 3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

Issue 1979953002: Remove OwnPtr::release() calls in modules/ (part 3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

index b7c0c1d4793492af501bd5f0b63ffba4cd3ab5cb..7212149cbeacdb7e18a71301acbdb2e7f0763783 100644

--- a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

+++ b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

@@ -646,7 +646,7 @@ void DOMWebSocket::didReceiveBinaryMessage(PassOwnPtr<Vector<char>> binaryData)

binaryData->swap(*rawData->mutableData());

OwnPtr<BlobData> blobData = BlobData::create();

blobData->appendData(rawData.release(), 0, BlobDataItem::toEndOfFile);

- Blob* blob = Blob::create(BlobDataHandle::create(blobData.release(), size));

+ Blob* blob = Blob::create(BlobDataHandle::create(std::move(blobData), size));

recordReceiveTypeHistogram(WebSocketReceiveTypeBlob);

m_eventQueue->dispatch(MessageEvent::create(blob, SecurityOrigin::create(m_url)->toString()));

break;