Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1978583003: Remove use of WebTaskRunner::Task and SameThreadTask from Microtask (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Shironeko_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of WebTaskRunner::Task and SameThreadTask from Microtask Microtask uses WebTaskRunner::Task and SameThreadTask, but it is not necessary after the last use of Microtask::enqueueMicrotask(std::unique_ptr<WebTaskRunner::Task>) was removed by https://codereview.chromium.org/1976083002/. This CL makes Microtask to use SameThreadClosure directly. BUG=478194 Committed: https://crrev.com/272c48dea84453021a475c33bf1223173f645be4 Cr-Commit-Position: refs/heads/master@{#394014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Microtask.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Microtask.cpp View 1 chunk +4 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978583003/1
4 years, 7 months ago (2016-05-13 07:41:30 UTC) #2
hiroshige
PTAL.
4 years, 7 months ago (2016-05-13 08:00:14 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-13 08:01:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 09:11:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978583003/1
4 years, 7 months ago (2016-05-17 00:10:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 01:49:23 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 01:50:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/272c48dea84453021a475c33bf1223173f645be4
Cr-Commit-Position: refs/heads/master@{#394014}

Powered by Google App Engine
This is Rietveld 408576698