Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1977773002: Make SameThreadTask/CrossThreadTask internal and remove platform/Task.h (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
haraken, kinuko, tzik
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@Shironeko_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SameThreadTask/CrossThreadTask internal and remove platform/Task.h This CL moves SameThreadTask/CrossThreadTask to Source/platform/WebTaskRunner.cpp so that these classes are used only just before tasks are posted to WebTaskRunner. To do this, SameThreadTask in CanvasAsyncBlobCreator is replaced with SameThreadClosure. BUG=478194 Committed: https://crrev.com/4d8a25ed0fda8ac6203a5b25fbb7b9e2fae42971 Cr-Commit-Position: refs/heads/master@{#394051}

Patch Set 1 #

Patch Set 2 : Rebase. Use DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -101 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Microtask.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/platform/Task.h View 1 chunk +0 lines, -86 lines 0 comments Download
M third_party/WebKit/Source/platform/WebTaskRunner.cpp View 1 chunk +36 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977773002/1
4 years, 7 months ago (2016-05-13 07:51:05 UTC) #2
hiroshige
PTAL.
4 years, 7 months ago (2016-05-13 08:23:22 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-13 09:06:54 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-13 09:11:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 09:26:47 UTC) #9
kinuko
lgtm
4 years, 7 months ago (2016-05-13 14:13:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977773002/1
4 years, 7 months ago (2016-05-17 02:53:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/6545) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-17 02:55:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977773002/20001
4 years, 7 months ago (2016-05-17 03:08:33 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 04:44:03 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 04:44:54 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d8a25ed0fda8ac6203a5b25fbb7b9e2fae42971
Cr-Commit-Position: refs/heads/master@{#394051}

Powered by Google App Engine
This is Rietveld 408576698