Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1976083002: Make ImageLoader::Task non-WebTaskRunner::Task (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
kinuko, Nate Chapin
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Shironeko_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ImageLoader::Task non-WebTaskRunner::Task This removes the last callsite of Microtask::enqueueMicrotask(std::unique_ptr<WebTaskRunner::Task>) and enables removal of WebTaskRunner::Task from Microtask in https://codereview.chromium.org/1978583003. BUG=478194 Committed: https://crrev.com/e490883c5db19bd1f63115232fc415959f51ea2a Cr-Commit-Position: refs/heads/master@{#393868}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 3 chunks +3 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976083002/1
4 years, 7 months ago (2016-05-13 07:32:13 UTC) #2
hiroshige
PTAL.
4 years, 7 months ago (2016-05-13 07:57:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976083002/20001
4 years, 7 months ago (2016-05-16 02:49:32 UTC) #7
kinuko
lgtm
4 years, 7 months ago (2016-05-16 04:32:51 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 06:52:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976083002/20001
4 years, 7 months ago (2016-05-16 18:10:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 18:15:43 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:17:36 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e490883c5db19bd1f63115232fc415959f51ea2a
Cr-Commit-Position: refs/heads/master@{#393868}

Powered by Google App Engine
This is Rietveld 408576698