Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1978513003: Save federated credential's signon_realm in the correct format. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Save federated credential's signon_realm in the correct format. It should be "federation://<origin>/<federation provider>". After https://codereview.chromium.org/1946563003 it became just "<origin>" like for normal credentials. Therefore, password and federated credentials started to overwrite each other in the password storage. BUG=611035 TBR=cfroussios@chromium.org Review-Url: https://codereview.chromium.org/1965413003 Cr-Commit-Position: refs/heads/master@{#392994} (cherry picked from commit 032bf70d261ff99daeae51e28583fd23e2458415) Committed: https://chromium.googlesource.com/chromium/src/+/4c9e6fdc6f7288622d8030401190d0a25eca746f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 9 chunks +46 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
vasilii
4 years, 7 months ago (2016-05-13 13:44:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c9e6fdc6f7288622d8030401190d0a25eca746f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698