Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1965413003: Save federated credential's signon_realm in the correct format. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
cfroussios
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Save federated credential's signon_realm in the correct format. It should be "federation://<origin>/<federation provider>". After https://codereview.chromium.org/1946563003 it became just "<origin>" like for normal credentials. Therefore, password and federated credentials started to overwrite each other in the password storage. BUG=611035 Committed: https://crrev.com/032bf70d261ff99daeae51e28583fd23e2458415 Cr-Commit-Position: refs/heads/master@{#392994}

Patch Set 1 #

Patch Set 2 : fix more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M components/password_manager/content/browser/credential_manager_impl_unittest.cc View 1 9 chunks +42 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
vasilii
Hi Christos, please have a look.
4 years, 7 months ago (2016-05-11 17:01:18 UTC) #2
cfroussios
On 2016/05/11 17:01:18, vasilii wrote: > Hi Christos, > > please have a look. lgtm
4 years, 7 months ago (2016-05-11 17:21:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965413003/20001
4 years, 7 months ago (2016-05-11 17:24:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 18:16:13 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 18:18:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/032bf70d261ff99daeae51e28583fd23e2458415
Cr-Commit-Position: refs/heads/master@{#392994}

Powered by Google App Engine
This is Rietveld 408576698