Fix blacklisting password forms with Credential Manager API.

Fix blacklisting password forms with Credential Manager API.

The fix has two parts. Blacklisting the federated credential now works. The password bubble doesn't pop up for a federated credential when the site is blacklisted.

BUG=607945
Committed: https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a
Cr-Commit-Position: refs/heads/master@{#391260}

[vasilii, 2016-05-03 14:19:17]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-05-03 14:19:18]

Hi Vaclav,

please review the CL.

[vabr (Chromium), 2016-05-03 14:37:05]

LGTM, thanks!

Cheers,
Vaclav

P.S. I looked into pending_credentials_ and can confirm what you were telling:
if the password store is empty, they are just the observed form. And for
blacklisting, the assumption is that the store does not contain a matching form
already (otherwise Chrome won't offer to save it).

https://codereview.chromium.org/1946563003/diff/1/components/password_manager...
File components/password_manager/core/browser/password_form_manager.cc (right):

https://codereview.chromium.org/1946563003/diff/1/components/password_manager...
components/password_manager/core/browser/password_form_manager.cc:1147: // its
'skip_zero_click' value. We don't do this for non-API forms, as
nit: Please update the comment, we no longer add copy just the skip_zero_click.

[vabr (Chromium), 2016-05-03 14:39:31]

Also, once you fix the compilation on iOS, feel free to let me know and I'll
double-check that the downstream test for credential manager is fine as well.

[vasilii, 2016-05-03 15:12:53]

https://codereview.chromium.org/1946563003/diff/1/components/password_manager...
File components/password_manager/core/browser/password_form_manager.cc (right):

https://codereview.chromium.org/1946563003/diff/1/components/password_manager...
components/password_manager/core/browser/password_form_manager.cc:1147: // its
'skip_zero_click' value. We don't do this for non-API forms, as
On 2016/05/03 14:37:05, vabr (Chromium) wrote:
> nit: Please update the comment, we no longer add copy just the
skip_zero_click.

Done.

[vabr (Chromium), 2016-05-03 15:18:57]

lgtm

[vasilii, 2016-05-03 15:57:38]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-05-03 15:57:38]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1946563003/#ps40001
(title: "ios")

[commit-bot: I haz the power, 2016-05-03 15:58:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946563003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946563003/40001

[commit-bot: I haz the power, 2016-05-03 16:25:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 16:27:12]

Description was changed from

==========
Fix blacklisting password forms with Credential Manager API.

The fix has two parts. Blacklisting the federated credential now works. The
password bubble doesn't pop up for a federated credential when the site is
blacklisted.

BUG=607945
==========

to

==========
Fix blacklisting password forms with Credential Manager API.

The fix has two parts. Blacklisting the federated credential now works. The
password bubble doesn't pop up for a federated credential when the site is
blacklisted.

BUG=607945

Committed: https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a
Cr-Commit-Position: refs/heads/master@{#391260}
==========

[commit-bot: I haz the power, 2016-05-03 16:27:13]

Patchset 3 (id:??) landed as
https://crrev.com/60883bfb1b4e342024a59b402924abdc23db596a
Cr-Commit-Position: refs/heads/master@{#391260}