chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc - Issue 1978403003: [MD] Eliminate as many SetStyle(STYLE_BUTTON) calls as possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

Issue 1978403003: [MD] Eliminate as many SetStyle(STYLE_BUTTON) calls as possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

diff --git a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

index a25667ceab1763331cec31fa460021226fd5c66b..1b2b28947fa9da219f51071b97a40dc2e0989525 100644

--- a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

+++ b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

@@ -9,7 +9,7 @@

#include "components/constrained_window/constrained_window_views.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/resource_bundle.h"

-#include "ui/views/controls/button/label_button.h"

+#include "ui/views/controls/button/md_text_button.h"

#include "ui/views/controls/styled_label.h"

#include "ui/views/layout/grid_layout.h"

#include "ui/views/layout/layout_constants.h"

@@ -174,12 +174,10 @@ void AutoSigninFirstRunDialogView::InitWindow() {

BuildColumnSet(layout, DOUBLE_BUTTON_COLUMN_SET);

layout->StartRowWithPadding(0, DOUBLE_BUTTON_COLUMN_SET, 0,

3 * views::kRelatedControlVerticalSpacing);

- ok_button_ = new views::LabelButton(

+ ok_button_ = views::MdTextButton::CreateSecondaryUiButton(

this, l10n_util::GetStringUTF16(IDS_AUTO_SIGNIN_FIRST_RUN_OK));

- ok_button_->SetStyle(views::Button::STYLE_BUTTON);

- turn_off_button_ = new views::LabelButton(

+ turn_off_button_ = views::MdTextButton::CreateSecondaryUiButton(

this, l10n_util::GetStringUTF16(IDS_AUTO_SIGNIN_FIRST_RUN_TURN_OFF));

- turn_off_button_->SetStyle(views::Button::STYLE_BUTTON);

layout->AddView(ok_button_);

layout->AddView(turn_off_button_);

layout->AddPaddingRow(0, views::kButtonVEdgeMarginNew);