Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1978313003: Reland of Client side display item cache flag (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@ScrollbarTheme
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Client side display item cache flag (patchset #1 id:1 of https://codereview.chromium.org/1979133003/ ) Reland the CL on m53 to diagnose the crashes. Original issue's description: > Revert of Client side display item cache flag (patchset #20 id:380001 of https://codereview.chromium.org/1508223005/ ) > > Reason for revert: > This caused crbug.com/609218. It seems that there is some short-lived > DisplayItemClient but needs more investigations to find which > DisplayItemClient it is. > > Revert this to unblock m-52 branch and beta release. > > Will reland on m-53 and add some code in release builds to find the > reason. > > BUG=609218 > > Original issue's description: > > Client side display item cache flag > > > > This is to reduce cost of hash lookups in PaintController. > > See platform/graphics/paint/README.md and DisplayItemClient.h > > for how it works. > > > > BUG=550044 > > > > Committed: https://crrev.com/93b971703db1f49a431ddeec2ebc884a232ee6de > > Cr-Commit-Position: refs/heads/master@{#390763} > > TBR=chrishtr@chromium.org,pdr@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=550044 > > Committed: https://crrev.com/1a26c7816d8feb358aaa87536e803b17facb16ae > Cr-Commit-Position: refs/heads/master@{#393930} TBR=chrishtr@chromium.org,pdr@chromium.org BUG=609218 Committed: https://crrev.com/3a9770f9d63c013d9d9727191102719a26228f6e Cr-Commit-Position: refs/heads/master@{#395549}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Rebase #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -135 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 1 2 3 4 5 3 chunks +54 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp View 1 2 3 5 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 1 2 3 4 5 6 9 chunks +17 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 3 4 5 6 7 24 chunks +79 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/README.md View 1 1 chunk +46 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/FakeDisplayItemClient.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 31 (18 generated)
Xianzhu
Created Reland of Client side display item cache flag
4 years, 7 months ago (2016-05-16 22:43:56 UTC) #1
chrishtr
lgtm
4 years, 7 months ago (2016-05-17 21:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978313003/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978313003/280001
4 years, 7 months ago (2016-05-23 19:26:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/10053) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-23 19:28:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978313003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978313003/300001
4 years, 7 months ago (2016-05-23 19:46:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/141855)
4 years, 7 months ago (2016-05-23 20:04:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978313003/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978313003/320001
4 years, 7 months ago (2016-05-23 22:13:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/141964) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-23 22:32:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978313003/360001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978313003/360001
4 years, 7 months ago (2016-05-24 00:21:52 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/142054)
4 years, 7 months ago (2016-05-24 00:41:12 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978313003/400001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978313003/400001
4 years, 7 months ago (2016-05-24 03:49:59 UTC) #26
commit-bot: I haz the power
Committed patchset #8 (id:400001)
4 years, 7 months ago (2016-05-24 09:02:27 UTC) #29
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 09:04:08 UTC) #31
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/3a9770f9d63c013d9d9727191102719a26228f6e
Cr-Commit-Position: refs/heads/master@{#395549}

Powered by Google App Engine
This is Rietveld 408576698