Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1979133003: Revert of Client side display item cache flag (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@ScrollbarTheme
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Client side display item cache flag (patchset #20 id:380001 of https://codereview.chromium.org/1508223005/ ) Reason for revert: This caused crbug.com/609218. It seems that there is some short-lived DisplayItemClient but needs more investigations to find which DisplayItemClient it is. Revert this to unblock m-52 branch and beta release. Will reland on m-53 and add some code in release builds to find the reason. BUG=609218 Original issue's description: > Client side display item cache flag > > This is to reduce cost of hash lookups in PaintController. > See platform/graphics/paint/README.md and DisplayItemClient.h > for how it works. > > BUG=550044 > > Committed: https://crrev.com/93b971703db1f49a431ddeec2ebc884a232ee6de > Cr-Commit-Position: refs/heads/master@{#390763} TBR=chrishtr@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=550044 Committed: https://crrev.com/1a26c7816d8feb358aaa87536e803b17facb16ae Cr-Commit-Position: refs/heads/master@{#393930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -149 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 2 chunks +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 5 chunks +25 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 9 chunks +34 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/README.md View 1 chunk +3 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/FakeDisplayItemClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
Xianzhu
Created Revert of Client side display item cache flag
4 years, 7 months ago (2016-05-16 18:03:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133003/1
4 years, 7 months ago (2016-05-16 18:04:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133003/1
4 years, 7 months ago (2016-05-16 18:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133003/1
4 years, 7 months ago (2016-05-16 19:01:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133003/1
4 years, 7 months ago (2016-05-16 19:31:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133003/1
4 years, 7 months ago (2016-05-16 20:01:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133003/1
4 years, 7 months ago (2016-05-16 20:31:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133003/1
4 years, 7 months ago (2016-05-16 21:01:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 21:18:58 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a26c7816d8feb358aaa87536e803b17facb16ae Cr-Commit-Position: refs/heads/master@{#393930}
4 years, 7 months ago (2016-05-16 21:21:40 UTC) #12
Xianzhu
4 years, 7 months ago (2016-05-16 22:43:56 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1978313003/ by wangxianzhu@chromium.org.

The reason for reverting is: Reland the CL on m53 to diagnose the crashes..

Powered by Google App Engine
This is Rietveld 408576698