Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977843002: [turbofan] Simplify handling of JSON tracing files. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_fix-trace-turbo-again
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplify handling of JSON tracing files. R=bmeurer@chromium.org Committed: https://crrev.com/cc340be945e8d1a1ad74200c673682e29f64c1ee Cr-Commit-Position: refs/heads/master@{#36242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -79 lines) Patch
M src/compiler/graph-visualizer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/pipeline.cc View 7 chunks +50 lines, -73 lines 0 comments Download

Depends on Patchset:

Issue 1976123002 Patch 1

Dependent Patchsets:

Issue 1972323004 Patch 1
Issue 1972323004 Patch 20001

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-13 12:31:23 UTC) #1
Benedikt Meurer
LGTM.
4 years, 7 months ago (2016-05-13 13:09:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977843002/1
4 years, 7 months ago (2016-05-13 13:40:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 13:43:14 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 13:44:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cc340be945e8d1a1ad74200c673682e29f64c1ee
Cr-Commit-Position: refs/heads/master@{#36242}

Powered by Google App Engine
This is Rietveld 408576698