Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1976123002: [turbofan] Fix --trace-turbo handle dereferences. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix --trace-turbo handle dereferences. Whenever tracing is activated we disable concurrent compilation. Hence all tracing functions can safely dereference all handles. This fixes the tracing functionality by annotating tracing functions with proper scopes. R=bmeurer@chromium.org Committed: https://crrev.com/0a60924e260572bcccbd88633b33e2d9ca349019 Cr-Commit-Position: refs/heads/master@{#36241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/compiler/pipeline.cc View 7 chunks +13 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-13 11:50:46 UTC) #1
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-13 13:09:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976123002/1
4 years, 7 months ago (2016-05-13 13:26:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 13:29:42 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 13:31:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a60924e260572bcccbd88633b33e2d9ca349019
Cr-Commit-Position: refs/heads/master@{#36241}

Powered by Google App Engine
This is Rietveld 408576698