Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1972323004: [turbofan] Escape analysis treats guard nodes as escaping. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-pipeline-json-printing
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Escape analysis treats guard nodes as escaping. This makes escape analysis treat all guard nodes in the graph as an escaping use. We eventually want to properly handle guard nodes, this just serves as a temporary workaround to get things going. R=bmeurer@chromium.org BUG=chromium:602595 LOG=n Committed: https://crrev.com/7cef5593e45eeb505f1aa3f04d3974b18c86ac20 Cr-Commit-Position: refs/heads/master@{#36286}

Patch Set 1 #

Patch Set 2 : All JS operators are escaping. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/compiler/escape-analysis.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-602595.js View 1 chunk +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-13 13:26:57 UTC) #1
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-13 13:27:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972323004/20001
4 years, 7 months ago (2016-05-17 15:43:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 15:47:17 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 15:47:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cef5593e45eeb505f1aa3f04d3974b18c86ac20
Cr-Commit-Position: refs/heads/master@{#36286}

Powered by Google App Engine
This is Rietveld 408576698