Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1977753002: Revert of [Reland] Implement CPU time for OS X and POSIX. (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Reland] Implement CPU time for OS X and POSIX. (patchset #1 id:1 of https://codereview.chromium.org/1966183003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1972303002/ Original issue's description: > [Reland] Implement CPU time for OS X and POSIX. > > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch > implements CPU time for OS X and POSIX to provide more accurate > accounting of CPU time used by each thread. > > BUG=v8:4984 > LOG=n > > Committed: https://crrev.com/efa27fb25e1fa5b8465f4af710086b73b0cba660 > Cr-Commit-Position: refs/heads/master@{#36213} TBR=fmeawad@chromium.org,jochen@chromium.org,rsesek@chromium.org,bmeurer@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4984 Committed: https://crrev.com/31b9ba3bc8fb93601cc73c83213b30e639d448b3 Cr-Commit-Position: refs/heads/master@{#36225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -127 lines) Patch
M src/base/platform/time.h View 2 chunks +1 line, -26 lines 0 comments Download
M src/base/platform/time.cc View 4 chunks +6 lines, -73 lines 0 comments Download
M test/unittests/base/platform/time-unittest.cc View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Michael Hablich
Created Revert of [Reland] Implement CPU time for OS X and POSIX.
4 years, 7 months ago (2016-05-13 07:07:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977753002/1
4 years, 7 months ago (2016-05-13 07:08:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 07:08:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31b9ba3bc8fb93601cc73c83213b30e639d448b3 Cr-Commit-Position: refs/heads/master@{#36225}
4 years, 7 months ago (2016-05-13 07:10:05 UTC) #5
lpy
May I ask the reason please? The reason saying 'blocks roll' doesn't provide enough information ...
4 years, 7 months ago (2016-05-13 07:13:36 UTC) #6
jochen (gone - plz use gerrit)
On 2016/05/13 at 07:13:36, lpy wrote: > May I ask the reason please? The reason ...
4 years, 7 months ago (2016-05-13 07:14:33 UTC) #7
lpy
On 2016/05/13 07:14:33, jochen (OOO) wrote: > On 2016/05/13 at 07:13:36, lpy wrote: > > ...
4 years, 7 months ago (2016-05-13 07:18:09 UTC) #8
Michael Hablich
4 years, 7 months ago (2016-05-13 11:05:13 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1976603005/ by hablich@chromium.org.

The reason for reverting is: Not the culprit sorry..

Powered by Google App Engine
This is Rietveld 408576698