Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1966183003: [Reland] Implement CPU time for OS X and POSIX. (Closed)

Created:
4 years, 7 months ago by lpy
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Reland] Implement CPU time for OS X and POSIX. V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch implements CPU time for OS X and POSIX to provide more accurate accounting of CPU time used by each thread. BUG=v8:4984 LOG=n Committed: https://crrev.com/efa27fb25e1fa5b8465f4af710086b73b0cba660 Cr-Commit-Position: refs/heads/master@{#36213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -7 lines) Patch
M src/base/platform/time.h View 2 chunks +26 lines, -1 line 0 comments Download
M src/base/platform/time.cc View 4 chunks +73 lines, -6 lines 0 comments Download
M test/unittests/base/platform/time-unittest.cc View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lpy
PTAL. This is a reland of the CPU time patch.
4 years, 7 months ago (2016-05-11 21:19:55 UTC) #2
Benedikt Meurer
LGTM.
4 years, 7 months ago (2016-05-12 04:15:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966183003/1
4 years, 7 months ago (2016-05-12 15:32:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 15:34:10 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/efa27fb25e1fa5b8465f4af710086b73b0cba660 Cr-Commit-Position: refs/heads/master@{#36213}
4 years, 7 months ago (2016-05-12 15:35:46 UTC) #10
Michael Hablich
4 years, 7 months ago (2016-05-13 07:07:59 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1977753002/ by hablich@chromium.org.

The reason for reverting is: Blocks roll:
https://codereview.chromium.org/1972303002/.

Powered by Google App Engine
This is Rietveld 408576698