Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1977733003: Use clang "--target=x" rather than "-target x" for icecc (Closed)

Created:
4 years, 7 months ago by tsniatowski
Modified:
4 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use clang "--target=x" rather than "-target x" for icecc Icecc is confused by the two-argument -target form and ends up compiling everything locally. It works with the equivalent single argument form, so prefer this in GN compiler configs. Previously done just for android in https://codereview.chromium.org/1871813003 Committed: https://crrev.com/f167315cf808e4047916cbd07b3d12b5f5a6fdf1 Cr-Commit-Position: refs/heads/master@{#394065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -38 lines) Patch
M build/config/compiler/BUILD.gn View 4 chunks +12 lines, -38 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tsniatowski
On 2016/05/13 09:52:12, tsniatowski wrote: > mailto:tsniatowski@opera.com changed reviewers: > + mailto:agrieve@chromium.org PTAL
4 years, 7 months ago (2016-05-13 09:52:20 UTC) #3
agrieve
On 2016/05/13 09:52:20, tsniatowski wrote: > On 2016/05/13 09:52:12, tsniatowski wrote: > > mailto:tsniatowski@opera.com changed ...
4 years, 7 months ago (2016-05-17 01:42:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977733003/1
4 years, 7 months ago (2016-05-17 04:30:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 05:54:26 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 05:56:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f167315cf808e4047916cbd07b3d12b5f5a6fdf1
Cr-Commit-Position: refs/heads/master@{#394065}

Powered by Google App Engine
This is Rietveld 408576698