Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1871813003: Use clang "--target=x" on android to help icecc (Closed)

Created:
4 years, 8 months ago by tsniatowski
Modified:
4 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use clang "--target=x" on android to help icecc Icecc is confused by the two-argument "-target x" form, and decides to compile everything locally. --target=x makes it happy. Committed: https://crrev.com/e4199397e4c6f32cf6a561e33581d59b5a7a0e9e Cr-Commit-Position: refs/heads/master@{#386419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M build/config/android/BUILD.gn View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tsniatowski
4 years, 8 months ago (2016-04-08 10:58:03 UTC) #3
agrieve
On 2016/04/08 10:58:03, tsniatowski wrote: lgtm
4 years, 8 months ago (2016-04-11 17:06:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871813003/1
4 years, 8 months ago (2016-04-11 17:41:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 18:25:38 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 18:27:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4199397e4c6f32cf6a561e33581d59b5a7a0e9e
Cr-Commit-Position: refs/heads/master@{#386419}

Powered by Google App Engine
This is Rietveld 408576698