Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1977733003: Use clang "--target=x" rather than "-target x" for icecc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 830b0aa7b2251d8867020561f8630fa458f35e4e..4ce96fa79b65cc8d67a44de4d49f4cef866549bd 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -505,14 +505,8 @@ config("compiler_cpu_abi") {
}
} else if (current_cpu == "arm") {
if (is_clang && !is_android && !is_nacl) {
- cflags += [
- "-target",
- "arm-linux-gnueabihf",
- ]
- ldflags += [
- "-target",
- "arm-linux-gnueabihf",
- ]
+ cflags += [ "--target=arm-linux-gnueabihf" ]
+ ldflags += [ "--target=arm-linux-gnueabihf" ]
}
if (!is_nacl) {
cflags += [
@@ -534,14 +528,10 @@ config("compiler_cpu_abi") {
if (mips_arch_variant == "r6") {
if (is_clang) {
cflags += [
- "-target",
- "mipsel-linux-gnu",
+ "--target=mipsel-linux-gnu",
"-march=mips32r6",
]
- ldflags += [
- "-target",
- "mipsel-linux-gnu",
- ]
+ ldflags += [ "--target=mipsel-linux-gnu" ]
} else {
cflags += [
"-mips32r6",
@@ -558,26 +548,18 @@ config("compiler_cpu_abi") {
if (is_clang) {
if (is_android) {
cflags += [
- "-target",
- "mipsel-linux-android",
+ "--target=mipsel-linux-android",
"-march=mipsel",
"-mcpu=mips32r2",
]
- ldflags += [
- "-target",
- "mipsel-linux-android",
- ]
+ ldflags += [ "--target=mipsel-linux-android" ]
} else {
cflags += [
- "-target",
- "mipsel-linux-gnu",
+ "--target=mipsel-linux-gnu",
"-march=mipsel",
"-mcpu=mips32r2",
]
- ldflags += [
- "-target",
- "mipsel-linux-gnu",
- ]
+ ldflags += [ "--target=mipsel-linux-gnu" ]
}
} else {
cflags += [
@@ -592,26 +574,18 @@ config("compiler_cpu_abi") {
if (is_clang) {
if (is_android) {
cflags += [
- "-target",
- "mipsel-linux-android",
+ "--target=mipsel-linux-android",
"-march=mipsel",
"-mcpu=mips32",
]
- ldflags += [
- "-target",
- "mipsel-linux-android",
- ]
+ ldflags += [ "--target=mipsel-linux-android" ]
} else {
cflags += [
- "-target",
- "mipsel-linux-gnu",
+ "--target=mipsel-linux-gnu",
"-march=mipsel",
"-mcpu=mips32",
]
- ldflags += [
- "-target",
- "mipsel-linux-gnu",
- ]
+ ldflags += [ "--target=mipsel-linux-gnu" ]
}
} else {
cflags += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698