Add metrics for permission prompt acceptance / denial

Add metrics for permission prompt acceptance / denial

BUG=603384
Committed: https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709
Cr-Commit-Position: refs/heads/master@{#395800}

[benwells, 2016-05-13 05:58:22]

benwells@chromium.org changed reviewers:
+ tsergeant@chromium.org

[benwells, 2016-05-13 05:58:23]

Tim for initial pass. \o/

https://codereview.chromium.org/1977693003/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/permission_ui_uma_util.cc (left):

https://codereview.chromium.org/1977693003/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/permission_ui_uma_util.cc:1: // Copyright
2016 The Chromium Authors. All rights reserved.
I accidentally committed this dud file :|

[tsergeant, 2016-05-16 03:18:09]

Looks like you're missing the corresponding changes to histograms.xml?

(+ there are some test failures)

[benwells, 2016-05-20 04:24:53]

On 2016/05/16 03:18:09, tsergeant wrote:
> Looks like you're missing the corresponding changes to histograms.xml?
> 
> (+ there are some test failures)

Woops, should be good now

[benwells, 2016-05-20 08:52:02]

On 2016/05/20 04:24:53, benwells wrote:
> On 2016/05/16 03:18:09, tsergeant wrote:
> > Looks like you're missing the corresponding changes to histograms.xml?
> > 
> > (+ there are some test failures)
> 
> Woops, should be good now

Actually I should add some tests to this, please hold off on reviewing until
I've done that.

[benwells, 2016-05-24 03:57:24]

Tests added, ptal...

[tsergeant, 2016-05-24 07:15:54]

lgtm

[benwells, 2016-05-24 07:20:11]

benwells@chromium.org changed reviewers:
+ isherman@chromium.org

[benwells, 2016-05-24 07:20:11]

+isherman for histograms

[benwells, 2016-05-24 07:20:13]

+isherman for histograms

[Ilya Sherman, 2016-05-25 00:22:19]

lgtm

[benwells, 2016-05-25 00:22:46]

The CQ bit was checked by benwells@chromium.org

[Ilya Sherman, 2016-05-25 00:23:07]

Though, one nit about clarity:

https://codereview.chromium.org/1977693003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1977693003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:36737: +  <summary>Tracks the permission
bubbles that are denied.</summary>
FWIW, it might be helpful to clarify whether this histogram tracks merged
bubbles, or only non-merged ones.

[commit-bot: I haz the power, 2016-05-25 00:23:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977693003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977693003/40001

[benwells, 2016-05-25 00:31:36]

The CQ bit was unchecked by benwells@chromium.org

[benwells, 2016-05-25 00:59:02]

https://codereview.chromium.org/1977693003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1977693003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:36737: +  <summary>Tracks the permission
bubbles that are denied.</summary>
On 2016/05/25 00:23:06, Ilya Sherman wrote:
> FWIW, it might be helpful to clarify whether this histogram tracks merged
> bubbles, or only non-merged ones.

Done.

[benwells, 2016-05-25 00:59:17]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-05-25 00:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1977693003/#ps60001
(title: "Clarify histogram descriptions")

[commit-bot: I haz the power, 2016-05-25 00:59:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977693003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977693003/60001

[commit-bot: I haz the power, 2016-05-25 02:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 02:22:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[benwells, 2016-05-25 03:07:05]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2016-05-25 03:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977693003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977693003/60001

[commit-bot: I haz the power, 2016-05-25 04:20:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-25 04:23:07]

Description was changed from

==========
Add metrics for permission prompt acceptance / denial

BUG=603384
==========

to

==========
Add metrics for permission prompt acceptance / denial

BUG=603384

Committed: https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709
Cr-Commit-Position: refs/heads/master@{#395800}
==========

[commit-bot: I haz the power, 2016-05-25 04:23:09]

Patchset 4 (id:??) landed as
https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709
Cr-Commit-Position: refs/heads/master@{#395800}