Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5635)

Unified Diff: chrome/browser/ui/website_settings/mock_permission_bubble_request.h

Issue 1977693003: Add metrics for permission prompt acceptance / denial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify histogram descriptions Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/mock_permission_bubble_request.h
diff --git a/chrome/browser/ui/website_settings/mock_permission_bubble_request.h b/chrome/browser/ui/website_settings/mock_permission_bubble_request.h
index 424c403b8e550da936c924ed0e0ce9ac6db4053d..38f27b88a2740e585557d9823cd134b1bf56884c 100644
--- a/chrome/browser/ui/website_settings/mock_permission_bubble_request.h
+++ b/chrome/browser/ui/website_settings/mock_permission_bubble_request.h
@@ -13,11 +13,13 @@ class MockPermissionBubbleRequest : public PermissionBubbleRequest {
public:
MockPermissionBubbleRequest();
explicit MockPermissionBubbleRequest(const std::string& text);
- explicit MockPermissionBubbleRequest(const std::string& text,
- const GURL& url);
- explicit MockPermissionBubbleRequest(const std::string& text,
- const std::string& accept_label,
- const std::string& deny_label);
+ MockPermissionBubbleRequest(const std::string& text,
+ PermissionBubbleType bubble_type);
+ MockPermissionBubbleRequest(const std::string& text, const GURL& url);
+ MockPermissionBubbleRequest(const std::string& text,
+ const std::string& accept_label,
+ const std::string& deny_label);
+
~MockPermissionBubbleRequest() override;
int GetIconId() const override;
@@ -28,15 +30,22 @@ class MockPermissionBubbleRequest : public PermissionBubbleRequest {
void PermissionDenied() override;
void Cancelled() override;
void RequestFinished() override;
+ PermissionBubbleType GetPermissionBubbleType() const override;
bool granted();
bool cancelled();
bool finished();
private:
+ MockPermissionBubbleRequest(const std::string& text,
+ const std::string& accept_label,
+ const std::string& deny_label,
+ const GURL& url,
+ PermissionBubbleType bubble_type);
bool granted_;
bool cancelled_;
bool finished_;
+ PermissionBubbleType bubble_type_;
base::string16 text_;
base::string16 accept_label_;

Powered by Google App Engine
This is Rietveld 408576698