Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3050)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 1977693003: Add metrics for permission prompt acceptance / denial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify histogram descriptions Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index c4c8001d215749510c9f390aad526442da0db199..f16361737f09855b8c60492354361cddbffb109f 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -38,6 +38,14 @@ enum PermissionAction {
// Provides a convenient way of logging UMA for permission related operations.
class PermissionUmaUtil {
public:
+ static const char kPermissionsPromptShown[];
+ static const char kPermissionsPromptAccepted[];
+ static const char kPermissionsPromptDenied[];
+ static const char kPermissionsPromptRequestsPerPrompt[];
+ static const char kPermissionsPromptMergedBubbleTypes[];
+ static const char kPermissionsPromptMergedBubbleAccepted[];
+ static const char kPermissionsPromptMergedBubbleDenied[];
+
static void PermissionRequested(content::PermissionType permission,
const GURL& requesting_origin,
const GURL& embedding_origin,
@@ -65,6 +73,18 @@ class PermissionUmaUtil {
static void PermissionPromptShown(
const std::vector<PermissionBubbleRequest*>& requests);
+ // The following two functions can be combined with the PermissionPromptShown
+ // metrics to calculate accept, deny and ignore rates.
+ // Note that for coalesced permission bubbles, PermissionPromptAccepted will
+ // always be called, with |accept_states| containing whether each request was
+ // accepted or denied.
+ static void PermissionPromptAccepted(
+ const std::vector<PermissionBubbleRequest*>& requests,
+ const std::vector<bool>& accept_states);
+
+ static void PermissionPromptDenied(
+ const std::vector<PermissionBubbleRequest*>& requests);
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
};
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698